Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vnets) enable Keyvault and Storage endpoints for infracijio-agents-1 subnet #258

Conversation

dduportal
Copy link
Contributor

@dduportal dduportal commented Jun 20, 2024

Related to jenkins-infra/helpdesk#3923, this PR enable Azure Network endpoints for KeyVaults and Storage on the subnet used by the infracijio-agents-1 cluster.

Note: we also need to add the parent vnet in the allowed vnets of the keyvault for infra.ci

@dduportal dduportal marked this pull request as ready for review June 20, 2024 14:08
@dduportal dduportal requested a review from a team June 20, 2024 14:08
Copy link
Contributor

@smerle33 smerle33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@dduportal dduportal enabled auto-merge (squash) June 20, 2024 14:09
@dduportal dduportal merged commit e8a5672 into jenkins-infra:main Jun 20, 2024
2 checks passed
@dduportal dduportal deleted the feat/vnet/infra.ci-subscription-keyvault branch June 20, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants